-
Notifications
You must be signed in to change notification settings - Fork 93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Also add instructions for this change in the readme.
- Handle the same case for uninstallation
@willemml
otherwise.. implementation itself looks great and thanks for contributing! |
Thanks for the feedback! I'm working on the implementation for the uninstall script, should I add a flag getopt loop to it as well? |
Would this be to loop around instead of |
I just looked at the Linux uninstall script and it would be exactly the same thing (looping through each flag). |
Ahh, for the |
03ea3aa
to
985d215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution.
@jetfir3 please verify and merge.
Looks good. |
I wanted to use this while having nix home-manager manager my Spotify install, this means that Spotify is not installed in the usual location.
This PR simply adds a flag
-a
that allows a user to specify the path of the Spotify app.