Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub components under MU #4

Closed
SKMan opened this issue Sep 28, 2018 · 16 comments
Closed

Sub components under MU #4

SKMan opened this issue Sep 28, 2018 · 16 comments

Comments

@SKMan
Copy link

SKMan commented Sep 28, 2018

Hi. Would very much like to know how you could achieve components under components, like;
chat-history -> message -> embedded-resource.

Have been trying this but I got "cannot find component".

Thanks.

@NullVoxPopuli
Copy link
Owner

how are you trying to invoke the component that results in "cannot find component"?
can you give an example component structure / templates?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

structure: src / ui / components / ok-form / ok-form-input

In route template:
<OkForm>form</OkForm>

in ok-form template:
<OkFormInput>input</OkFormInput>

OkFormInput could not be found and gives the error

@NullVoxPopuli
Copy link
Owner

is it:

src/ui/components/
- ok-form/
  component.js
  template.hbs // has <OkFormInput>input</OkFormInput>
  - ok-form-input/
    comporent.js
    template.hbs

?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

Exactly

@NullVoxPopuli
Copy link
Owner

what version of ember-source and ember-cli are you using?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

same as yours, copied from your package.json

@NullVoxPopuli
Copy link
Owner

how are you starting ember s?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

EMBER_CLI_MODULE_UNIFICATION=true ember s

@NullVoxPopuli
Copy link
Owner

what do you have in your environment.js?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

copied yours as well

@NullVoxPopuli
Copy link
Owner

what about optional-features.json?

@NullVoxPopuli
Copy link
Owner

also, if you clone this repo, does the project run?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

No I didn't clone, just took necessary parts. By the way, I'm trying that in an MU addon. Do you think this is the issue?

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

Same structure works in dummy app's own components but when I add addon's components into dummy app, it cannot find. Sorry I should've mentioned that before.

@NullVoxPopuli
Copy link
Owner

yeah, I don't know if MU addons are ready for testing. could review in: emberjs/ember.js#16373 to see what needs to be done to land support.

@SKMan
Copy link
Author

SKMan commented Sep 28, 2018

Thank you so much. Sorry, took your time.

@SKMan SKMan closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants