Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State-aware trackedFunction + function-based Resources #437

Merged
merged 2 commits into from
May 1, 2022

Conversation

NullVoxPopuli
Copy link
Owner

No description provided.

@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch from c87602d to 321c628 Compare April 10, 2022 14:47
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6d96ce4
Status: ✅  Deploy successful!
Preview URL: https://c5123ebd.ember-resources.pages.dev

View logs

@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch from 321c628 to 8ca0ed4 Compare April 25, 2022 00:40
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/core/index.js 3.84 kB 1.75 kB 832 B 698 B
/util/ember-concurrency.js 5.17 kB 1.54 kB 737 B 625 B
/util/function-resource.js 6.18 kB 1.79 kB 787 B 647 B
/util/function.js 3.34 kB 1.23 kB 577 B 492 B
/util/helper.js 1.8 kB 303 B 219 B 202 B
/util/map.js 4.07 kB 1.29 kB 679 B 576 B

@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch 2 times, most recently from 98d7f43 to 13bec63 Compare April 25, 2022 17:22
@NullVoxPopuli NullVoxPopuli changed the title State-aware trackedFunction State-aware trackedFunction + function-based Resources Apr 25, 2022
@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch 6 times, most recently from 520eb6a to 4fbad59 Compare May 1, 2022 18:43
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 1, 2022 18:47
@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch 2 times, most recently from 1b15e30 to 7c14985 Compare May 1, 2022 19:08
trackedFunction is powered by an *also* new `resource` function (exported from
uti/function-resource).

`trackedFunction` now has additional state information, such as
- isLoading
- isPending
- isError
- isResolved
- error
- value (pre-existing)

To use the function-resource, you'll need the @use decorator

This is a different `@use` from before, and is why it's exported from
the same import path as the function-resource.

There was pretty much no usage of the old `@use`, so I think this change
is ok.
@NullVoxPopuli NullVoxPopuli force-pushed the add-state-aware-tracked-function branch from 7c14985 to 6d96ce4 Compare May 1, 2022 19:14
@NullVoxPopuli NullVoxPopuli merged commit 547f925 into main May 1, 2022
@NullVoxPopuli NullVoxPopuli deleted the add-state-aware-tracked-function branch May 1, 2022 19:19
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant