Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with ecosystem and prepare for v5 #426

Merged
merged 13 commits into from
Apr 9, 2022

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Mar 30, 2022

See MIGRATION.md for details

Resolves: #363, #195, #48
Adopts: https://github.com/NullVoxPopuli/ember-array-map-resource (which will be deprecated after this is merged)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 30, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d79c66
Status: ✅  Deploy successful!
Preview URL: https://f2099976.ember-resources.pages.dev

View logs

@NullVoxPopuli NullVoxPopuli force-pushed the sync-with-ecosystem-prepare-for-v5 branch 5 times, most recently from bdc459f to f6faa9e Compare April 9, 2022 12:01
this helps existing users not pull in the new APIs and increase their
payload.
It also provides an easy migration when v5 lands such that the existing
"default entrypoint" aka "ember-resources" will become re-exports from
just "core". This is an improvement over the previous "All exports"
because common feedback I've heard about ember-resources is that folks
only what to pay for what they use.

So,
 - in v4
   - importing from ember-resources will include everything, more than
     what some folks are using
   - importing from ember-resources/core will only add "core" code to your bundle
   - importing from ember-resources/util will only add what you use to your bundle
 - in v5
   - importing from ember-resources will _only_ be "core" code.
   - importing from ember-resources/util will only add what you use to your bundle
@NullVoxPopuli NullVoxPopuli force-pushed the sync-with-ecosystem-prepare-for-v5 branch from 75a8cd0 to 11e4c00 Compare April 9, 2022 13:07
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review April 9, 2022 17:14
@NullVoxPopuli NullVoxPopuli merged commit b2354a6 into main Apr 9, 2022
@NullVoxPopuli NullVoxPopuli deleted the sync-with-ecosystem-prepare-for-v5 branch April 9, 2022 17:38
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the implementation of trackedFunction such that loading/error state are revealed
1 participant