fix: @ember/test-waiters must be a peer dependency
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See explanation: #403 (comment) tldr: peerDeps are the only way to guarantee that modern packagers only load one version (specified by the consumer)
Deploying with
|
| Latest commit: |
7913d1c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69286304.ember-resources.pages.dev |
|
🎉 This PR is included in version 4.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@NullVoxPopuli I don't see any change here which makes test-waiters a peerDependency? Looking on master it's still in dependencies |
|
bah, I must have confused myself during a rebase :( |
mrloop
added a commit
to mrloop/ember-material-modifier
that referenced
this pull request
Sep 9, 2022
repo using ember-material-modifier could not resolve test-waiters See explanation NullVoxPopuli/ember-resources#407 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See explanation: #403 (comment)
tldr: peerDeps are the only way to guarantee that modern packagers
only load one version (specified by the consumer)
Interesting discovery while testing this: