Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration output #1094

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix declaration output #1094

merged 1 commit into from
Jan 9, 2024

Conversation

NullVoxPopuli
Copy link
Owner

Due to floating dependencies, a dev-env TS Upgrade, incorrect (for the ember ecosystem) type declarations were created -- using /// <reference.

We don't want these, because it breaks expectations of the consumer importing a module containing a ton of declare module (or using the @types packages).

To fix this, I made a new tool: https://github.com/NullVoxPopuli/fix-bad-declaration-output

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jan 9, 2024
Copy link

stackblitz bot commented Jan 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 27.09 kB 6.34 kB 2.36 kB 2.08 kB
├── core/class-based/index.js 10.25 kB 3.12 kB 1.42 kB 1.22 kB
├── core/function-based/index.js 15.01 kB 4.12 kB 1.55 kB 1.35 kB
└── core/use.js 11.18 kB 3.46 kB 1.4 kB 1.22 kB
/link.js 3.28 kB 913 B 507 B 421 B
/service.js 22.1 kB 6.95 kB 2.49 kB 2.19 kB
/util/debounce.js 3.71 kB 1.44 kB 712 B 607 B
/util/ember-concurrency.js 5.71 kB 2.19 kB 1.04 kB 890 B
/util/fps.js 3.79 kB 1.48 kB 760 B 624 B
/util/function.js 10.71 kB 3.36 kB 1.29 kB 1.12 kB
/util/helper.js 2.77 kB 885 B 495 B 415 B
/util/keep-latest.js 3.31 kB 1.06 kB 568 B 478 B
/util/map.js 6.55 kB 2.99 kB 1.36 kB 1.15 kB
/util/remote-data.js 8.64 kB 2.99 kB 1.1 kB 941 B

Copy link
Contributor

github-actions bot commented Jan 9, 2024

@NullVoxPopuli NullVoxPopuli merged commit 80634c5 into v6 Jan 9, 2024
28 checks passed
@NullVoxPopuli NullVoxPopuli deleted the fix-declarations branch January 9, 2024 22:48
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant