-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom usables, regusterUsable
#1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
Estimated impact to a consuming app, depending on which bundle is imported
|
Preview URLsreadme: https://d19c001f.ember-resources.pages.dev |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important public API to formally support things like
ember-modify-based-class-resource
, as well as allow others to create usables in their libraries.registerUsable
is a very light wrapper aroundinvokeHelper
that allows customization of how args are pasesd to to the "helper"For example, if ember-concurrency wanted to integrate with the usable system, they could do something like this:
Provided that:
definition
is registered with the helper-manager system.config
object has atype
property with value set toember-concurrency
-- in practice this would be a property set on the result of theirtask
function.registerUsable
is used in two places at the time of putting this PR up:This PR had a cascading affect which allowed the removal of some old Types that were previously only used for the class-based implementation.