Use local beta version of ember-cli #87
Conversation
|
|
|
simonihmig
force-pushed
the
fix-ts-flag
branch
3 times, most recently
from
de7a8c0
to
8c8cd1b
Compare
cli/src/v2-blueprint.js
Outdated
| info.name, | ||
| `--dir=${addonDir}`, | ||
| // needs https://github.com/embroider-build/addon-blueprint/pull/137 for proper TS support | ||
| '--blueprint=embroider-build/addon-blueprint#update-for-upstream-ts-changes', |
There was a problem hiding this comment.
- Use a new published version once we have Update for ember-cli
--typescriptchanges embroider-build/addon-blueprint#137 merged.
There was a problem hiding this comment.
Reverted that, it's now using the npm published blueprint again, which as of https://github.com/embroider-build/addon-blueprint/releases/tag/v1.7.0 contains all the things we need
There was a problem hiding this comment.
What could go wrong? 🙃
Tho. CLI shourd be released in the next couple days 🤞
(I'm approving this, since i it fixes the ts stuff, but we'll want to at least back off to beta once available)
((I can always hold off on publishing to npm until real versions are used))
This changes the way we invoke ember-cli, to use our own dependency, so we control the version of the blueprint. And (for now) we use the latest canary version, to use the fixed `--typescript` support.
|
I rebased and changed to again use the npm published blueprint, but now tests are failing 🤔 ... need to investigate... |
| @@ -44,7 +44,6 @@ | |||
| "ember-cli-sri": "^2.1.1", | |||
| "ember-cli-terser": "^4.0.2", | |||
| "ember-disable-prototype-extensions": "^1.1.3", | |||
| "ember-export-application-global": "^2.0.1", | |||
There was a problem hiding this comment.
Had to remove this, which is deprecated anyway, as with the new ember-cli we get Ember 5 apps created, which this is incompatible with. This was the reason for CI failing...
There was a problem hiding this comment.
I wonder if the migration code should remove it?
References 5.2.0-beta.0 now instead of master! :) |
simonihmig
changed the title
This changes the way we invoke ember-cli, to use our own dependency, so we control the version of the blueprint. And (for now) we use the latest canary version, to use the fixed
--typescriptsupport.