-
Notifications
You must be signed in to change notification settings - Fork 4
Xlmodel 202510 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Xlmodel 202510 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to db3f8e0 in 2 minutes and 16 seconds. Click for details.
- Reviewed
213lines of code in3files - Skipped
17files when reviewing. - Skipped posting
19draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:3
- Draft comment:
Updated testing note now indicates Windows version (>=2025.10) instead of Linux-only. Please verify this change aligns with the current platform support. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:15
- Draft comment:
The link to 'NucleiStudio_User_Guide.pdf' has been updated to the 202510 version. Confirm that the updated document URL is correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:28
- Draft comment:
Environment setup updated to reference 'NucleiStudio 2025.10 Windows' instead of the older Linux version. Ensure this reflects the intended primary platform. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:67
- Draft comment:
The profiling configuration instructions have been revised to use 'GDB Nuclei Model riscv Debugging' instead of the older 'RVProf' approach. Confirm that these revised steps match the current IDE interface. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:352
- Draft comment:
Cycle count values in the performance table have been updated (from 154,988/35,619 to 161,108/42,066). Please verify that these new figures accurately reflect performance measurements with the updated model. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:279
- Draft comment:
The original Nuclei Model package download link has been updated. Please confirm that the new link is correct and accessible. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:307
- Draft comment:
In the section describing how to retrieve the compiled model executable, the download links and instructions have been updated. Verify that both provided options are valid and clear. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:3
- Draft comment:
Updated the testing environment note to reflect usage on Windows (>=2025.10) instead of the previous version. Confirm consistency with other documentation. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
9. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:30
- Draft comment:
The download links for NucleiStudio have been updated to the 202510 versions for both Windows and Linux. Please ensure these URLs are correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
10. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:36
- Draft comment:
The xlmodel_nice package download links have been updated to new URLs. Verify that the new links (for both Windows and Linux) are accessible. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
11. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:58
- Draft comment:
The profiling configuration instructions have been revised to use 'GDB Nuclei Model riscv Debugging'. Confirm that the new instructions are accurate and user-friendly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
12. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:72
- Draft comment:
A note has been added specifying that for Nuclei Studio (<2025.10) the ELF file is located at 'build/default/xl_cpumodel'. Please verify that this information is correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
13. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:196
- Draft comment:
Cycle statistics in the comparison table have been updated with slight numerical adjustments. Please ensure that these new measurements (e.g., 3844 cycles, 122 cycles) are correctly calculated. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
14. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:200
- Draft comment:
The URL for the optimized xlmodel_nice package has been updated. Confirm that the new link is valid and the package is available. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
15. README.md:33
- Draft comment:
The generated timestamp has been updated to '2025-12-05 16:17:56'. This update appears correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
16. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:22
- Draft comment:
Typo notice: In the sentence starting with 'NICE/VNICE使得用户可以结合自己的应用扩展自定义指令,将芯来的标准处理器核扩展成为面向领域专用的处理器...'. The term '芯来的' appears unusual—please verify if it should be '芯片的' or another intended term. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
17. 18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.md:84
- Draft comment:
Typographical note: The image alt text is 'image-ase_demo_cycle' while the referenced file is 'aes_demo_cycle.png'. Consider correcting 'ase' to 'aes' to maintain consistency. - Reason this comment was not posted:
Comment was on unchanged code.
18. 19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.md:56
- Draft comment:
There appears to be a typographical error in the image file name on this line. "Nuclei_Settting" may be intended to be "Nuclei_Setting". Please verify and update if necessary. - Reason this comment was not posted:
Comment was on unchanged code.
19. README.md:37
- Draft comment:
Typo: The file name '3-print_memor_usage_in_ide.md' appears to have a misspelling ('memor' should likely be 'memory'). Please correct it. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_ufgetYNLwDxpZtGO
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将 Nuclei Studio xlmodel 相关的 doc 更新适配到 202510
Important
Update documentation to align with Nuclei Studio version 2025.10, including configuration and profiling instructions.
18-demonstrate_NICE_VNICE_acceleration_of_the_Nuclei_Model_through_profiling.mdto reflect Nuclei Studio version 2025.10, including changes in configuration steps and profiling results.19-rapid_verification_of_NICE_VNICE_acceleration_with_Nuclei_Model_and_NICE_Wizard.mdto reflect Nuclei Studio version 2025.10, including changes in configuration steps and profiling results.README.mdto 2025-12-05.This description was created by
for db3f8e0. You can customize this summary. It will automatically update as commits are pushed.