Fix to Issue#181 (JuliaDynamics#380)

* added rstrip() also to both parameters in collect_results!.

* added rstrip() to both parameters in collect_results!.

* Changed projectdir() to always cut off trailing slashes.

* Moved rstrip to the correct place within projectdir().

* Added test to check for the bug.

* Removed my test to make sure the others are working with my changes.

* Set a wrong bracket.

* Readded my test since other tests are still working.

* Changed wording in comment.

* Checking if my test tests correctly.

* Test working as intended!.

* Rewriting test with ending var.

* Working version of the test.

* Removed unnecessary brackets.

src/project_setup.jl

@@ -31,7 +31,7 @@ function projectdir()
     end
     dirname(Base.active_project())
 end
-projectdir(args...) = joinpath(projectdir(), args...)
+projectdir(args...) = rstrip(joinpath(projectdir(), args...), '/')
 
 
 # Generate functions to access the path of default subdirectories.

src/result_collection.jl

@@ -73,7 +73,7 @@ In case this operation fails the values will be treated as `missing`.
 """
 collect_results!(folder; kwargs...) =
 collect_results!(
-joinpath(dirname(folder), "results_$(basename(folder)).jld2"),
+joinpath(dirname(rstrip(folder, '/')), "results_$(rstrip(basename(folder), '/')).jld2"),
 folder; kwargs...)
 
 struct InvalidResultsCollection <: Exception

test/update_results_tests.jl

@@ -64,6 +64,19 @@ cres_relpath = collect_results!(relpathname, folder;
     rpath = projectdir())
 @info all(startswith.(cres[!,"path"], "data"))
 
+###############################################################################
+#                           Trailing slash in foldername                      #
+###############################################################################
+
+df = collect_results!(datadir("results/"))      # This would produce the incorrect file. (Issue#181)
+
+pathtofile=datadir("results/results_.jld2")     # 
+@test !isfile(pathtofile)
+
+if isfile(pathtofile)
+    rm(pathtofile)                              # In case this test failed, remove the file to not compromise other tests.
+end
+
 ###############################################################################
 #                           Include or exclude files                          #
 ###############################################################################