Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

We only need one url for a repo #637

Merged
merged 5 commits into from
Jan 19, 2019

Conversation

AnthonySteele
Copy link
Member

@AnthonySteele AnthonySteele commented Jan 6, 2019

We only need one url for a repo. The difference between HtmlUrl and CloneUrl is not clear, I think it's duplication. #633

Needs testing with github

@AnthonySteele
Copy link
Member Author

AnthonySteele commented Jan 9, 2019

The issue may be that when matching the git url, it exists in 2 forms that need to be matched with each other
on the browser url bar it is e.g. https://github.myco.com/SomeTeam/SomeApi
if you "clone with https" it is e.g. https://github.myco.com/SomeTeam/SomeApi.git

We should consider these equivalent, but that should be done in the github handling code, not in the source-control-platform-independent Repository class

@AnthonySteele AnthonySteele merged commit 080d6a1 into NuKeeperDotNet:master Jan 19, 2019
@AnthonySteele AnthonySteele deleted the one-url branch January 20, 2019 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants