-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document GlobalPackageReference #2876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One small suggestion.
@@ -176,6 +176,28 @@ If you'd like to disable central package management for any a particular project | |||
</PropertyGroup> | |||
``` | |||
|
|||
## Global Package References |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should the title be GlobalPackageReference
to improve discoverability or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since its a title it is better to have it spelled out. GlobalPackageReference is mentioned a few times in the body so it should show up in internet searches
Docs Build status updates of commit b192f97: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small suggestion for consideration(feel free to discard) to add the reasoning of the example and summarize what it does.
Co-authored-by: Jon Douglas <jodou@microsoft.com>
Docs Build status updates of commit 8140a7d: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Fixes NuGet/Home#12073