Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GlobalPackageReference #2876

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Sep 7, 2022

@jeffkl jeffkl requested review from a team as code owners September 7, 2022 17:48
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One small suggestion.

@@ -176,6 +176,28 @@ If you'd like to disable central package management for any a particular project
</PropertyGroup>
```

## Global Package References
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should the title be GlobalPackageReference to improve discoverability or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since its a title it is better to have it spelled out. GlobalPackageReference is mentioned a few times in the body so it should show up in internet searches

@jeffkl jeffkl closed this Sep 8, 2022
@jeffkl jeffkl reopened this Sep 8, 2022
@opbld31
Copy link

opbld31 commented Sep 8, 2022

Docs Build status updates of commit b192f97:

✅ Validation status: passed

File Status Preview URL Details
docs/consume-packages/Central-Package-Management.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion for consideration(feel free to discard) to add the reasoning of the example and summarize what it does.

Co-authored-by: Jon Douglas <jodou@microsoft.com>
@opbld31
Copy link

opbld31 commented Sep 8, 2022

Docs Build status updates of commit 8140a7d:

✅ Validation status: passed

File Status Preview URL Details
docs/consume-packages/Central-Package-Management.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jeffkl jeffkl merged commit 53d4923 into main Sep 8, 2022
@jeffkl jeffkl deleted the dev-jeffkl-document-global-package-reference branch September 8, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document GlobalPackageReference
4 participants