This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Support already configured TelemetryConfiguration for LoggingSetup #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierdecoster
requested review from
joelverhagen,
agr,
loic-sharma,
ryuyu,
cristinamanum,
skofman1 and
zhhyu
xavierdecoster
commented
Dec 6, 2019
| @@ -59,7 +59,7 @@ public TelemetryClientWrapper(TelemetryClient telemetryClient) | |||
| { | |||
| Timestamp = timestamp, | |||
| Name = metricName, | |||
| Value = value | |||
| Sum = value | |||
There was a problem hiding this comment.
Whilst at it: the MetricTelemetry.Value property is also obsolete and replaced by Sum
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LoggingSetupshould no longer use theTelemetryConfiguration.Activestatic, and must support providing an already configuredTelemetryConfigurationinstance again.Even though this method call is marked
[Obsolete]for this SeriLog sink, there's currently no other way to pass in the activeTelemetryConfigurationas configured in DI.These SeriLog APIs are very likely to change again to support passing in the
TelemetryConfigurationsomehow, in light ofTelemetryConfiguration.Activebeing deprecated by AI.See also serilog-contrib/serilog-sinks-applicationinsights#121.