This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Work-around heartbeat interval initialization bug in AI #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierdecoster
commented
Nov 19, 2019
…insights.config file
agr
approved these changes
Nov 19, 2019
loic-sharma
approved these changes
Nov 21, 2019
Make DiagnosticsTelemetryModule accessible to allow tweaking heartbeats.
|
Updated the PR with:
|
xavierdecoster
requested review from
joelverhagen,
cristinamanum,
ryuyu and
skofman1
xavierdecoster
commented
Nov 26, 2019
| /// | ||
| /// It is the caller's responsibility to ensure the returned configuration is used | ||
| /// when creating new <see cref="TelemetryClient"/> instances. | ||
| /// </remarks> |
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified changes locally against the solution that reproduced the AppInsights bug, and this work-around works.
Also need to verify our usage of
TelemetryConfiguration.Activethroughout the code consuming this library, as that API is being deprecated, andTelemetryConfiguration.Activewon't pick up this custom initialized instance.