[Rename] Display rename information on package detail page #7964
Conversation
zhhyu
requested review from
agr,
cristinamanum,
dannyjdev,
joelverhagen,
loic-sharma,
ryuyu,
shishirx34,
skofman1 and
xavierdecoster
as code owners
zhhyu
removed request for
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1 and
dannyjdev
zhhyu
changed the title
zhhyu
changed the title
zhhyu
changed the title
tests/NuGetGallery.Facts/Controllers/PackagesControllerFacts.cs
Outdated
Show resolved
Hide resolved
zhhyu
requested review from
agr,
cristinamanum,
dannyjdev,
ryuyu,
shishirx34 and
skofman1
| // Configure the rename information container | ||
| var container = $('#show-rename-content-container'); | ||
| window.nuget.configureExpander("rename-content-container", "ChevronDown", null, "ChevronUp"); | ||
| container.keydown(function (event) { |
There was a problem hiding this comment.
This should be DRY with the deprecation below. Shared function, loop, whatever.
| @{ | ||
| if (Model.PackageRenames.Count == 1) | ||
| { | ||
| @:This package has been renamed |
There was a problem hiding this comment.
Period at the end of sentence.
| } | ||
| else | ||
| { | ||
| @:This package has been renamed or split into new packages |
There was a problem hiding this comment.
Period at the end of sentence.
| } | ||
|
|
||
| public IReadOnlyList<PackageRename> GetPackageRenames(PackageRegistration packageRegistration) | ||
| { |
There was a problem hiding this comment.
Will this new query significantly impact the display package page performance?
| @@ -837,11 +840,14 @@ public virtual async Task<ActionResult> DisplayPackage(string id, string version | |||
| .GroupBy(d => d.PackageKey) | |||
| .ToDictionary(g => g.Key, g => g.First()); | |||
|
|
|||
| var packageRenames = _renameService.GetPackageRenames(package.PackageRegistration); | |||
There was a problem hiding this comment.
This should be behind the flag as well, so we can turn if off if perf is an issue.
|
It's behind the feature flag now. If the feature flag is turned off, there will be no impact on loading the package page, and nothing related to rename will be triggered. |
Addresses #7907