Add a polyfill to enable newer compiler features #10315
Open
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New versions of C# offer many features that improve quality of life: nullable annotations, record types, init and required properties, etc. These can be enabled in projects targeting older framework versions by adding the right attributes and types to the compilation. PolySharp is a source generator which automatically does this. For each project, it will generate all of the types/attributes which are missing. In the case of an InternalsVisibleTo reference, it is smart enough to only define types in the second assembly that are not being consumed from the first assembly (avoiding duplicate type definitions).
jimmylewis
force-pushed
the
jamlew-compilerpolyfill
branch
from
3185208 to
d6b5c7e
Compare
joelverhagen
reviewed
Jan 7, 2025
| @@ -19,6 +19,44 @@ public void ShouldOnlyHaveInterfacesAndEnums() | |||
| // included in the assembly by newer language versions | |||
| "Microsoft.CodeAnalysis.EmbeddedAttribute", | |||
| "System.Runtime.CompilerServices.RefSafetyRulesAttribute", | |||
| // generated polyfills from PolySharp | |||
| "System.Runtime.CompilerServices.NullableAttribute", | |||
There was a problem hiding this comment.
Hmm I wonder if we can filter out internal types for this test. This test appears to be a "public contract changes should be acknowledged by this test".
There was a problem hiding this comment.
we could easily check only types where type.IsVisible is true
true if the current Type is a public type or a public nested type such that all the enclosing types are public; otherwise, false.
joelverhagen
previously approved these changes
Jan 7, 2025
joelverhagen
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of C# offer many features that improve quality of life: nullable annotations, record types, init and required properties, etc. These can be enabled in projects targeting older framework versions by adding the right attributes and types to the compilation.
PolySharp is a source generator which automatically does this. For each project, it will generate all of the types/attributes which are missing. In the case of an InternalsVisibleTo reference, it is smart enough to only define types in the second assembly that are not being consumed from the first assembly (avoiding duplicate type definitions).