Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Search] Consider boosting direct dependencies over transitive dependencies #7186

Open
karann-msft opened this issue May 28, 2019 · 2 comments

Comments

@karann-msft
Copy link
Contributor

karann-msft commented May 28, 2019

3.x+ clients don't send info if a download is a direct or transitive install. As a result, we don't have an accurate count of direct installs which ends up boosting package ranking.

Target queries:

@joelverhagen provided some additional context, caveats, and workarounds for the metalama case here: #9485 (comment).

@karann-msft karann-msft changed the title Transitive packages have a higher download count due to parent packages which, boosting relevancy [Azure Search] Transitive packages have a higher download count due to parent packages which boosts relevancy May 28, 2019
@joelverhagen
Copy link
Member

Some thoughts:

Dependencies come and go from version to version. We should consider looking at all versions of a package to determine all of the direct dependencies it has ever had. Then, we can map that to a list of dependencies per package ID, weighted by the relative number of downloads per version.

The specific case we care most about is core packages depended on by a top level "productized" package. For example, xunit is top level and xunit.core is core. Microsoft.AspNetCore.Mvc is top level and Microsoft.AspNetCore.Mvc.Core is core. These cases have the same owner. We should consider only doing the download count subtraction for packages that have the same owners (or perhaps share a common owner).

Dependencies vary from TFM to TFM. We can consider weighting the dependency by TFM frequency perhaps as defined by client telemetry on project restore TFM.

@loic-sharma loic-sharma changed the title [Azure Search] Transitive packages have a higher download count due to parent packages which boosts relevancy [Azure Search] Consider boosting direct dependencies over transitive dependencies Aug 9, 2019
@loic-sharma
Copy link
Contributor

Another customer report: #8782 (comment)

Searching with the keyword "maui" comes up with primarily transitive dependencies.

Target query: maui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants