Embed NuGet files in the binary log after restore completes

[jeffkl]

Bug

Fixes: NuGet/Home#12374

Regression? No Last working version:

Description

This updates the Restore task to embed NuGet files in the binlog after Restore is complete. Even if restore fails, any files that exist will be embedded:

In this case the package name is wrong and the .dgspec is still in the binlog.

For static graph-based restore, the output paths are logged back to the RestoreTaskEx so it can embed the files in the binlog at the end of the actual build. I could not find a way to embed them in the nuget.binlog that contains evaluation...

Related to dotnet/sdk#16840

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception - It would be hard to verify the contents of the binlog at the moment.
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[jeffkl]

FYI @KirillOsenkov!

[erdembayar]

Cool. 👏

[KirillOsenkov]

I would swap the AND branches and check for EmbedProjectAssetsFile first, then check for Exists after AND. I can't remember why, but we broke someone by still hitting the disk for Exists when it was turned off.

See here:
https://github.com/dotnet/sdk/pull/20624/files

[KirillOsenkov]

Here was the issue where we were reading the file unnecessarily and this broke deterministic/distributed build:
dotnet/sdk#20556

[jeffkl]

I'm closing this for now because I'm not 100% happy with it. Currently, only the project.assets.json file of the entry project is captured since it runs after the Restore target. So if you restore 50 projects, you only get one, which I don't think is very useful. I'll spend some time coming up with a better solution...