Updated NU1012 error message to display item paths #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the NU1012 error message created in PackageBuilder to display a comma-delimited list of item paths instead of a list of frameworks. Updated the SavingPackageValidatesMissingTPVInFiles unit test in PackageBuilderTests to adjust the expected results accordingly. The comment for the MissingTargetPlatformVersionsFromIncludedFiles string resource in Strings.resx ("0 - comma-separated list of files with bad TFMs") suggests that this was the original intent for this message. Resolves #11905.
ghost
added
the
|
|
nkolev92
approved these changes
Oct 5, 2022
|
Thanks for the contribution @danjagnow Can you please fill out the checklist and follow the instructions in the template? It'd be great to create a docs issue to update the example there, https://github.com/NuGet/docs.microsoft.com-nuget/blob/main/docs/reference/errors-and-warnings/NU1012.md. |
erdembayar
approved these changes
Oct 5, 2022
|
@nkolev92, I did my best to fill out the template. Hopefully that's better. Let me know if there are other changes I should make. Thanks for providing the link to the docs for NU1012. |
|
Looks great @danjagnow, thank you. |
|
@nkolev92 @dominoFire |
|
Merged. |
dominoFire
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11905
Regression? Last working version:
Description
Updated the NU1012 error message created in
PackageBuilderto display a comma-delimited list of item paths instead of a list of frameworks. Updated theSavingPackageValidatesMissingTPVInFilesunit test inPackageBuilderTeststo adjust the expected results accordingly. The comment for theMissingTargetPlatformVersionsFromIncludedFilesstring resource in Strings.resx ("0 - comma-separated list of files with bad TFMs") suggests that this was the original intent for this message. Resolves #11905.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation