fixed NuGet.config missing issue #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,8 @@ public static class NuGetConstants | |||
|
|
|||
| public static readonly string FeedName = "nuget.org"; | |||
|
|
|||
| public static readonly string AddV3TrackFile = "AddV3Track.config"; | |||
There was a problem hiding this comment.
Call the file NuGetOrgAdd.trk and base the behavior on the existence of the file.
| @@ -24,6 +24,8 @@ public static class NuGetConstants | |||
|
|
|||
| public static readonly string FeedName = "nuget.org"; | |||
|
|
|||
| public static readonly string AddV3TrackFile = "NuGetOrgAdd.trk"; | |||
There was a problem hiding this comment.
let's make this all lower to avoid xplat issues like we have with nuget.config
|
Verify that loading the machine wide settings is cached here and isn't read an extra time just for this check. If it does we should look at checking this lazily after zero sources are found. |
|
Verified machine wide is cached, this check is only for appdata setting, will not read machine wide here |
|
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet/Home#2445
the fix here is to check nuget.config in appdata, if there is no source, add nuget.org to it and create a track file. If the track file exist, nuget will not add nuget.org again.
And this fix is only for global nuget.config.
tested upgrading from 3.3 to 3.4 scenario, it works well