-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running MSBuild static graph restore display additional log messages when project format is not known to MSBuild #4126
Conversation
If you look at https://github.com/nuget/home/issues?q=is%3Aopen+is%3Aissue+label%3AArea%3ARestoreStaticGraph, you will find NuGet/Home#9026, which calls out this problem. |
8a0ee13
to
ef123e2
Compare
… static graph restore
ef123e2
to
2031bed
Compare
@NuGet/nuget-client team, I am waiting for second approval or additional feedback. |
Bug
Fixes: NuGet/Home#10363
Regression? Last working version:
Description
MSBuild static graph restore silently ignores projects in solution whose format is not known to MSBuild. Added following log messages which will be displayed at
Normal
verbosity.The solution did not have any projects to restore, ensure that all projects are known to be MSBuild and that the projects exist.
message will be logged when solution file doesn't have any projects to restore.The solution contains {count} project(s) "{list of projects}" that are not known to MSBuild. Ensure that all projects are known to be MSBuild before running restore on the solution.
message will be logged when a solution has projects whose format is not known to MSBuild.For some reason, MSBuild verbosity argument is not passed to NuGet. Hence NuGet always runs static graph restore logic in
Normal
verbosity. It is very much possible that I am missing something. Happy to learn based on the feedback from the team.NuGet.Client/src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Line 59 in 5d43a9c
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation