Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPVM in preview feature message information. #3376

Merged
merged 7 commits into from
May 28, 2020
Merged

Conversation

cristinamanum
Copy link
Contributor

Bug

Fixes: Add an information message on restore to inform the CPVM users that the feature is in preview.

Fix

Add a target that will display the information. Snapshots below.

Visual Studio
image

Msbuild output

CentralPackageVersionManagementPreview:
  The project TwoLevelPinning.csproj is using CentralPackageVersionManagement, a NuGet preview feature. See: https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions.
Restore:
  Restoring packages for E:\NuGet\TestProjects\CPVM\WithoutPackChanges\TransitivePinning\TwoLevelPinning\TwoLevelPinning.csproj...
  Committing restore...
  Generating MSBuild file E:\NuGet\TestProjects\CPVM\WithoutPackChanges\TransitivePinning\TwoLevelPinning\obj\TwoLevelPinning.csproj.nuget.g.props.
  Generating MSBuild file E:\NuGet\TestProjects\CPVM\WithoutPackChanges\TransitivePinning\TwoLevelPinning\obj\TwoLevelPinning.csproj.nuget.g.targets.
  Writing assets file to disk. Path: E:\NuGet\TestProjects\CPVM\WithoutPackChanges\TransitivePinning\TwoLevelPinning\obj\project.assets.json```
## Testing/Validation

Tests Added: Yes
Validation:  E2E manual validation

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should capture all 4 products (and 3 entry points).

VS, NuGet.exe & MSBuild/dotnet.

Do we want to have 1 message per project or 1 per operation?

Note that in VS, we don't post once per restore messages often.

src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets Outdated Show resolved Hide resolved
src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets Outdated Show resolved Hide resolved
@cristinamanum cristinamanum requested a review from nkolev92 May 22, 2020 22:07
@cristinamanum cristinamanum requested a review from nkolev92 May 27, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an information message on restore to inform the CPVM users that the feature is in preview
2 participants