Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS client certificate support #3273

Merged
merged 11 commits into from
May 8, 2020
Merged

Add HTTPS client certificate support #3273

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
56d2fe9
Merge branch 'dev-blackgad-client-certs' into temp-branch
BlackGad May 1, 2020
dd7b5ac
Fixed new code analysis issues
BlackGad May 1, 2020
aa3ee03
Marked some tests as windows only
BlackGad May 1, 2020
9bf9560
Fixed ClientCertUpdatedCommand_Fail_StoreCertificateNotExist on Mac
BlackGad May 2, 2020
925c2c7
Fixed list command tests
BlackGad May 2, 2020
40ca27d
Excluded problematic tests from MacOS
BlackGad May 2, 2020
0ac32a3
Excluded additional tests from Mac
BlackGad May 4, 2020
18d35d5
Fixed similar to Xplat command line test for MacOS
BlackGad May 4, 2020
899dbca
Added SkipMono for all limited client cert tests
BlackGad May 4, 2020
98b2a9f
Reworked ClientCertArgs processing
BlackGad May 6, 2020
0899b48
Fixed and extended error handling in docs.tt
BlackGad May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Excluded additional tests from Mac
  • Loading branch information
@BlackGad
BlackGad committed May 6, 2020
commit 0ac32a3436bc446edf4ecd0fafe886669fa9b656
6 changes: 3 additions & 3 deletions test/NuGet.Clients.Tests/NuGet.CommandLine.Test/NuGetClientCertCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public void ClientCertAddCommand_Fail_StoreCertificateNotExist()
}
}

[Fact]
[PlatformFact(Platform.Windows)]
public void ClientCertAddCommand_Success_FileCertificateAbsolute()
{
// Arrange
Expand Down Expand Up @@ -242,7 +242,7 @@ public void ClientCertAddCommand_Success_FileCertificateNotExistForce()
}
}

[Fact]
[PlatformFact(Platform.Windows)]
public void ClientCertAddCommand_Success_FileCertificateRelative()
{
// Arrange
Expand Down Expand Up @@ -283,7 +283,7 @@ public void ClientCertAddCommand_Success_FileCertificateRelative()
}
}

[Fact]
[PlatformFact(Platform.Windows, Platform.Linux)]
public void ClientCertAddCommand_Success_StoreCertificate()
{
// Arrange
Expand Down