Feature spec for suppressing specific vulnerabilities #12921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skofman1
reviewed
Oct 31, 2023
|
|
||
| ## Prior Art | ||
|
|
||
| <!-- What prior art, both good and bad are related to this proposal? --> |
There was a problem hiding this comment.
When thinking about prior art we can draw inspiration from, consider GitHub dependabot suppressions, CG suppressions, NPM. It will be interesting to see the granularity that each solution provides (per package, per project, per advisory, etc.). Assuming that NuGet users already have experience using those other vuln suppression mechanism, they likely expect a similar customer experience from NuGet.
zivkan
force-pushed
the
zivkan-NuGetAudit-Supressions
branch
from
d6d61dd
to
98568e0
Compare
nkolev92
reviewed
Jan 25, 2024
nkolev92
reviewed
Jan 26, 2024
zivkan
commented
Mar 1, 2024
zivkan
commented
Mar 7, 2024
jeffkl
approved these changes
Mar 7, 2024
nkolev92
approved these changes
Mar 8, 2024
|
It's easy to forget about suppressions done in a config file that's not in your face. Are we thinking about some messaging (info) to state that? Like as part of restore, something like: "Note: Some warnings due to packages having vulnerabilities have been suppressed. See , for a list of those suppressions." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view rendered spec
Note: I don't expect this to get implemented particularly soon, and I'm not going to have a lot of capacity to make frequent updates to this spec, in case it gets a lot of feedback. But I'm putting it out there now, so it has time to get sufficient feedback before it gets accepted.