Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async implementation of IVS Package Installer/Uninstaller services #8896

Open
Tracked by #8872
nkolev92 opened this issue Dec 10, 2019 · 6 comments
Open
Tracked by #8872

Add async implementation of IVS Package Installer/Uninstaller services #8896

nkolev92 opened this issue Dec 10, 2019 · 6 comments
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Feature

Comments

@nkolev92
Copy link
Member

nkolev92 commented Dec 10, 2019 •
edited
Loading

Spawned from: #8892

Design started at #9103
@nkolev92 nkolev92 self-assigned this Dec 10, 2019
@nkolev92 nkolev92 added this to the Backlog milestone Dec 10, 2019
This was referenced Dec 10, 2019
Closed
Closed
Open
@nkolev92 nkolev92 changed the title Free threaded implementation of IVS Package Installer/Uninstaller services Async implementation of IVS Package Installer/Uninstaller services Dec 13, 2019
@nkolev92
Copy link
Member Author

Change all titles, we can't really be free threaded.
We call VS APIs that require the UI thread.

@nkolev92 nkolev92 mentioned this issue Dec 23, 2019
Closed
@nkolev92 nkolev92 modified the milestones: Backlog, Sprint 165 Jan 21, 2020
@nkolev92 nkolev92 removed this from the Sprint 165 - 2020.01.20 milestone Feb 25, 2020
@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org and removed NuGet API labels Apr 24, 2020
@nkolev92 nkolev92 removed their assignment May 20, 2020
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Jul 2, 2020
@nkolev92 nkolev92 added this to the Sprint 173 - 2020.07.24 milestone Jul 6, 2020
@nkolev92 nkolev92 removed this from the Sprint 173 - 2020.07.06 milestone Jul 20, 2020
@nkolev92 nkolev92 removed the Epic label Aug 15, 2020
@nkolev92
Copy link
Member Author

Spec at https://github.com/NuGet/Home/pull/9103/files

@nkolev92 nkolev92 removed the Priority:2 Issues for the current backlog. label Aug 15, 2020
@nkolev92 nkolev92 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Aug 15, 2020
@nkolev92
Copy link
Member Author

To understand the amount of effort required/leftover here, I cleaned up my old branch, https://github.com/NuGet/NuGet.Client/compare/dev-nkolev92-ivsinstaller.

I would argue that there's under a week of work leftover. Some of that work is design.

@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels May 13, 2021
@nkolev92
Copy link
Member Author

Pri3 shouldn't be in backlog. This is something we want to do, so adding back pri2.

@CyrusNajmabadi CyrusNajmabadi mentioned this issue May 13, 2021
Open
@aortiz-msft aortiz-msft added Priority:1 High priority issues that must be resolved in the current sprint. and removed Priority:2 Issues for the current backlog. labels Oct 19, 2021
@zivkan zivkan self-assigned this Oct 25, 2021
@zivkan zivkan modified the milestones: Sprint 2021-10, Sprint 2021-11 Oct 25, 2021
@nkolev92
Copy link
Member Author

nkolev92 commented Nov 2, 2021

Still picking this up @zivkan?

Should it be costed?

If you pick it up, feel free to borrow my branch as it's probably more than 50% done.

@nkolev92
Copy link
Member Author

nkolev92 commented Nov 3, 2021

@zivkan

The branch with the changes is up to date: https://github.com/NuGet/NuGet.Client/tree/dev-nkolev92-ivsinstaller.

This should hopefully make the implementation pretty simple.

For example, cutting the source parameter is trivial.

@zivkan zivkan removed their assignment Jan 3, 2022
@zivkan zivkan removed this from the Sprint 2021-11 milestone Jan 3, 2022
@nkolev92 nkolev92 mentioned this issue Apr 27, 2022
Open
3 tasks
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Oct 24, 2022
@nkolev92 nkolev92 self-assigned this Oct 24, 2022
@jeffkl jeffkl added Priority:2 Issues for the current backlog. and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Aug 17, 2023
@jeffkl jeffkl changed the title Async implementation of IVS Package Installer/Uninstaller services Add async implementation of IVS Package Installer/Uninstaller services Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nkolev92 @zivkan @jeffkl @heng-liu @aortiz-msft