Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All NuGet IVS APIs should be async #8872

Open
3 tasks
nkolev92 opened this issue Dec 3, 2019 · 1 comment
Open
3 tasks

All NuGet IVS APIs should be async #8872

nkolev92 opened this issue Dec 3, 2019 · 1 comment
Assignees
@zivkan
Labels
Epic Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Feature

Comments

@nkolev92
Copy link
Member

nkolev92 commented Dec 3, 2019 •
edited
Loading

The NuGet extensibility APIs in VisualStudio https://github.com/NuGet/NuGet.Client/tree/dev/src/NuGet.Clients/NuGet.VisualStudio/Extensibility are mostly synchronous and as such a common cause for UI delays.

Common offenders are:
https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.VisualStudio/Extensibility/IVsPackageInstallerServices.cs

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.VisualStudio/Extensibility/IVsPackageSourceProvider.cs

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.VisualStudio/Extensibility/IVsPackageInstaller.cs

These APIs can be furthermore improved by returning the actual status of the operation. Something not done in some of the synchronous APIs.

@kartheekp-ms specifically is looking into creating an async version for IVSPackageSourceProvider #8675

fyi @NuGet/nuget-client @dtivel

Roslyn ask
@nkolev92 nkolev92 added this to the Backlog milestone Dec 3, 2019
@nkolev92 nkolev92 mentioned this issue Mar 13, 2020
Closed
@CyrusNajmabadi
Copy link

Yes please. :)

@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. and removed NuGet API Triage:NeedsTriageDiscussion labels Apr 24, 2020
@nkolev92 nkolev92 added the Tenet:Performance Performance issues label May 18, 2020
@nkolev92 nkolev92 mentioned this issue May 18, 2020
Closed
@nkolev92 nkolev92 removed this from the Backlog milestone May 18, 2020
@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:2 Issues for the current backlog. labels Aug 21, 2020
@zivkan zivkan self-assigned this Oct 19, 2021
@zivkan zivkan added this to the Sprint 2021-11 milestone Oct 19, 2021
@zivkan zivkan removed this from the Sprint 2021-11 milestone Nov 2, 2021
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Dec 2, 2021
@nkolev92 nkolev92 added Epic and removed Epic labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Epic Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nkolev92 @CyrusNajmabadi @zivkan @heng-liu