Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuspec.xsd to include id regex #6124

Open
ohadschn opened this issue Oct 31, 2017 · 5 comments
Open

Update nuspec.xsd to include id regex #6124

ohadschn opened this issue Oct 31, 2017 · 5 comments
Labels
Functionality:Pack help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time
Milestone

Comments

@ohadschn
Copy link

The schema doesn't seem to impose any restrictions on them (even though XSD regex patterns are possible). The docs only say "IDs may not contain spaces or characters that are not valid for a URL".

But this is incomplete, as the implementation and tests suggest. Specifically, names must conform to ^\w+([_.-]\w+)*$. I don't know what the restrictions on version strings are, but I reckon there are some.

@emgarten
Copy link
Member

This issue was moved to NuGet/docs.microsoft.com-nuget#543

@emgarten emgarten added this to the 4.6 milestone Oct 31, 2017
@ohadschn
Copy link
Author

@emgarten does the schema (XSD) update part also fall under doc changes?

@emgarten emgarten reopened this Oct 31, 2017
@emgarten emgarten changed the title Package ID and Package Version restrictions - document + update schema Update nuspec.xsd to include id regex Oct 31, 2017
@emgarten emgarten modified the milestones: 4.6, Backlog Oct 31, 2017
@emgarten emgarten added Functionality:Pack help wanted Considered good issues for community contributions. and removed Type:Docs labels Oct 31, 2017
@emgarten
Copy link
Member

does the schema (XSD) update part also fall under doc changes?

Saw the link the docs for the schema, didn't see it was also in the client repo. I've opened this.

Would you be willing to send a PR to update the schema and verify that it works with the change you mentioned?

@ohadschn
Copy link
Author

ohadschn commented Nov 4, 2017

Where can I find the validation logic / regex for package versions?

@emgarten
Copy link
Member

@ohadschn take a look at NuGet.Packaging and the authoring validation there.

@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
@jeffkl jeffkl added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Pipeline:Icebox labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time
Projects
None yet
Development

No branches or pull requests

5 participants