Disabling the "Always show error list..." option is ignored by NuGet for legacy csproj

[mishra14]

VS Feedback ID: 480086

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe): VS

NuGet version (x.x.x.xxx): 4.4.4475

Detailed repro steps so we can see the same problem

1. Create a new legacy csproj project -> .NetFramework Class library

2. Tools -> Options -> NuGet Package Manager -> Set default format to PackageReference

3. Tools -> Options -> Projects and Solutions -> General -> Uncheck Always Show Error list....

4. Add a reference to a non existing package.

5. Build Project

Expected

The build fails but the error list is not displayed

Actual

The build fails, but the error list is displayed.

Other suggested things

We can do an additional check here to see if this option is set or not.

We should look at sdk code here and here that does the same thing for net core projects.