Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different msbuild task UserAgent strings for netcore vs desktop #5709

Closed
emgarten opened this issue Aug 3, 2017 · 0 comments
Closed

Add different msbuild task UserAgent strings for netcore vs desktop #5709

emgarten opened this issue Aug 3, 2017 · 0 comments
Assignees
@emgarten
Labels
Functionality:Restore Type:DCR Design Change Request
Milestone
4.4

Comments

@emgarten
Copy link
Member

emgarten commented Aug 3, 2017 •
edited by rrelyea
Loading

https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Build.Tasks/RestoreTask.cs#L26

The current agent is NuGet MSBuild Task

This should be split into NuGet .NET Core MSBuild Task and NuGet Desktop MSBuild Task

This will allow give a better indication of dotnet restore usage vs msbuild /t:restore usage.
@emgarten emgarten added this to the 4.4 - 7/31 through 8/18 milestone Aug 3, 2017
@emgarten emgarten self-assigned this Aug 3, 2017
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 4, 2017
@emgarten
Add msbuild task UserAgent strings for netcore vs desktop
60ec4ac 
Desktop framework will use: NuGet Desktop MSBuild Task
NETStandard will use: NuGet .NET Core MSBuild Task

Fixes NuGet/Home#5709
@emgarten emgarten mentioned this issue Aug 4, 2017
Merged
@emgarten emgarten modified the milestones: 4.4, 4.4 - 7/31 through 8/18 Aug 7, 2017
@emgarten emgarten mentioned this issue Aug 7, 2017
Closed
9 tasks
@rrelyea rrelyea added the Type:DCR Design Change Request label Aug 7, 2017
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 8, 2017
@emgarten
Add msbuild task UserAgent strings for netcore vs desktop
953b7d0 
Desktop framework will use: NuGet Desktop MSBuild Task
NETStandard will use: NuGet .NET Core MSBuild Task

Fixes NuGet/Home#5709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Functionality:Restore Type:DCR Design Change Request
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@emgarten @rrelyea