Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing new version of package from CLI with -ExcludeVersion should remove files from previously installed version #3957

Closed
nuke440 opened this issue Nov 16, 2016 · 0 comments · Fixed by NuGet/NuGet.Client#1634
Closed

Installing new version of package from CLI with -ExcludeVersion should remove files from previously installed version #3957

nuke440 opened this issue Nov 16, 2016 · 0 comments · Fixed by NuGet/NuGet.Client#1634
Assignees
@emgarten
Labels
Functionality:Install The install command in VS/nuget.exe Product:NuGet.exe NuGet.exe Style:Packages.Config
Milestone
4.4

Comments

@nuke440
Copy link

nuke440 commented Nov 16, 2016

Details about Problem

NuGet product used (NuGet.exe | VS UI | Package Manager Console | dotnet.exe):
NuGet.exe

NuGet version (x.x.x.xxx):
3.3.0

OS version (i.e. win10 v1607 (14393.321)):
Windows - Any

Description:
I would expect that when installing a new version of a package using -ExcludeVersion should also clean up files leftover from the previous version.

Detailed repro steps so we can see the same problem

  1. Install one version of a package using nuget.exe install with -ExcludeVersion

  2. Install different version of same package that doesn't have some of the files contained in the first package - also using -ExcludeVersion

  3. If files existed in the old version that don't exist in the new one, they are not cleaned up and you now you have a mix of files from both versions.

Thanks for considering this.
@rrelyea rrelyea added this to the Future-1 milestone Nov 16, 2016
@emgarten emgarten added Functionality:Install The install command in VS/nuget.exe and removed Triage:Investigate labels Aug 11, 2017
@emgarten emgarten modified the milestones: 4.4, Future-1 Aug 11, 2017
@emgarten emgarten self-assigned this Aug 11, 2017
@emgarten emgarten mentioned this issue Aug 11, 2017
Merged
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 12, 2017
@emgarten
Improvements for nuget.exe install
8614255 
* Allow updating packages when -ExcludeVersion is used
* Improved detection of already installed packages when -ExcludeVersion is used
* Adding -Framework switch to allow setting the target framework used when resolving dependencies.
* Remove NU1000 code from packages.config restore errors.
* Avoid unneeded downloads when a version is not given and the package is cached.
* Disable parallel for mono
* Display errors and return a non-zero exit when install on packages.config fails
* Remove old files during upgrades with -ExcludeVersion

Fixes NuGet/Home#5743
Fixes NuGet/Home#5737
Fixes NuGet/Home#5736
Fixes NuGet/Home#5741
Fixes NuGet/Home#5017
Fixes NuGet/Home#3957
Fixes NuGet/Home#2405
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Aug 12, 2017
@emgarten
Improvements for nuget.exe install
5b6edbb 
* Allow updating packages when -ExcludeVersion is used
* Improved detection of already installed packages when -ExcludeVersion is used
* Adding -Framework switch to allow setting the target framework used when resolving dependencies.
* Remove NU1000 code from packages.config restore errors.
* Avoid unneeded downloads when a version is not given and the package is cached.
* Disable parallel for mono
* Display errors and return a non-zero exit when install on packages.config fails
* Remove old files during upgrades with -ExcludeVersion

Fixes NuGet/Home#5743
Fixes NuGet/Home#5737
Fixes NuGet/Home#5736
Fixes NuGet/Home#5741
Fixes NuGet/Home#5017
Fixes NuGet/Home#3957
Fixes NuGet/Home#2405
@emgarten emgarten mentioned this issue Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Functionality:Install The install command in VS/nuget.exe Product:NuGet.exe NuGet.exe Style:Packages.Config
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Improvements for nuget.exe install NuGet/NuGet.Client
3 participants
@nuke440 @emgarten @rrelyea