Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring sources as authentication required or preferred #12451

Open
nkolev92 opened this issue Feb 23, 2023 · 2 comments
Open

Allow configuring sources as authentication required or preferred #12451

nkolev92 opened this issue Feb 23, 2023 · 2 comments
Assignees
Labels
Area:Authentication Area:HttpCommunication Area:Settings NuGet.Config and related issues Priority:2 Issues for the current backlog. Type:Feature

Comments

@nkolev92
Copy link
Member

NuGet Product(s) Involved

NuGet.exe, Visual Studio Package Management UI, MSBuild.exe, dotnet.exe

The Elevator Pitch

Today, the NuGet tooling relies on a 401 challenge to understand whether a source needs auth.
This adds a roundtrip for a few of the urls hit the client.

It would be nice, if NuGet would just try to acquire credentials for certain feeds as marked by the user.

This would mean no wasted requests and allow for the source to cleanly know the difference between an authenticated and unauthenticated user from the onset and maybe build some experiences of off that.

Additional Context and Details

The behavior today, only as needed works great when a feed is either fully public, no 401 challenges, or fully private, 401 challenge on every url, but it's not really smooth for sources that may for example be only partially public.

When I'm calling the source public/private, I'm only referring to the restore side. Push tends to require authn even on feeds that are public for restore.

@nkolev92 nkolev92 changed the title Allow configure sources as authentication required or preferred Allow configuring sources as authentication required or preferred Feb 23, 2023
@zivkan
Copy link
Member

zivkan commented Feb 23, 2023

More or less a duplicate of #11600. If there are differences between the two issues, I think they can be exaplained as a comment, rather than a new issue.

@zivkan zivkan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
@nkolev92 nkolev92 added the Resolution:Duplicate This issue appears to be a Duplicate of another issue label Feb 23, 2023
@zivkan
Copy link
Member

zivkan commented Mar 30, 2023

Apologies to @nkolev92. In the end I'm going to create an epic to track several different work items, as the implementation is becoming more complex, and this ("sub")feature request has different challenges that other parts of the feature.

@zivkan zivkan reopened this Mar 30, 2023
@jeffkl jeffkl added Priority:2 Issues for the current backlog. and removed Resolution:Duplicate This issue appears to be a Duplicate of another issue labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Authentication Area:HttpCommunication Area:Settings NuGet.Config and related issues Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
Development

No branches or pull requests

3 participants