Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static graph-based restore should always log an error on failure #12372

Closed
jeffkl opened this issue Jan 18, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5085
Closed

Static graph-based restore should always log an error on failure #12372

jeffkl opened this issue Jan 18, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5085
Assignees
@jeffkl
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Milestone
6.6

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Jan 18, 2023

NuGet Product(s) Affected

MSBuild.exe, dotnet.exe

Current Behavior

When static graph-based restore runs, the restore is run in a different process. The logic in this process has a few spots where something can go wrong and the EXE will not log an error. In rare cases, no error is logged and restore appears to succeed.

Desired Behavior

All places in the EXE's code where something can go wrong should log an error and the RestoreTaskEx should consider looking at the exit code in case its non-zero instead of only determining success/failure based on if any errors were logged.

Additional Context

No response
@jeffkl jeffkl added Priority:2 Issues for the current backlog. Type:DCR Design Change Request Area:RestoreStaticGraph Issues related to the Static Graph restore labels Jan 18, 2023
@jeffkl jeffkl self-assigned this Jan 18, 2023
@jeffkl jeffkl mentioned this issue Feb 6, 2023
Open
13 tasks
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue Mar 10, 2023
@jeffkl
Always log an error when static graph-based restore fails
82d8671 
NuGet/Home#12372
jeffkl added a commit to NuGet/NuGet.Client that referenced this issue Mar 10, 2023
@jeffkl
Always log an error when static graph-based restore fails
7eaa0d8 
NuGet/Home#12372
@jeffkl jeffkl mentioned this issue Mar 10, 2023
Merged
8 tasks
@jeffkl jeffkl added this to the 6.6 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
6.6
Development

Successfully merging a pull request may close this issue.

Always log an error when static graph-based restore fails NuGet/NuGet.Client
1 participant
@jeffkl