5.0.300 dotnet restore ignores proxy settings

[nkolev92]

@jirikopecky commented on Mon, 31 May 2021 14:34:05 GMT
Our build server is behind proxy and we use private NuGet feed. This feed have to be accessed directly, without the proxy. Feed DNS name is configured in no_proxy environment variable. dotnet restore fails with HTTP 504 Gateway Timeout.

Summaray:

• Environment: Docker (using mcr.microsoft.com/dotnet/sdk:5.0 image)
• Custom NuGet feed configured in NuGet.config (nuget.mycorp.com)
• HTTP(S) proxy configured using http_proxy and https_proxy env variables
• Using no_proxy env variable to configure direct access to custom feed (no_proxy=nuget.mycorp.com)
• Restore works with SDK 5.0.203, same setup fails with SDK 5.0.300

[nkolev92]

@dotnet-issue-labeler[bot] commented on Mon, 31 May 2021 14:34:08 GMT
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[nkolev92]

@tempel3 commented on Tue, 01 Jun 2021 07:25:39 GMT
Hello,

i have a similar issue.

While trying to setup a proxy WITH Authentication for the docker build using the nuget.config and environmental variables. The settings are ignored or not handled correctly.

For more information regarding the test setup, please ask.

Best regards
Paul

[nkolev92]

@protonyx commented on Wed, 02 Jun 2021 21:07:22 GMT
I noticed this same issue with SDK v5.0.300. If I clear my proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY), dotnet restore begins working (we also have a private feed on our intranet). It seems that the NO_PROXY environment variable is being ignored, even when I specify it in a solution-local nuget.config:

  <config>
    <add key="http_proxy" value="http://proxy.mycorp.com" />
    <add key="no_proxy" value=".mycorp.com" />
  </config>

[nkolev92]

@michal-ciechan commented on Wed, 09 Jun 2021 09:16:59 GMT
Adding from #6981 (comment)

---

My issue is that we need to use proxy for a single source. and not for others.

We have HTTP_PROXY set so that everything picks it up correctly.

We also have NO_PROXY set for various domains/IP ranges that cannot go through the proxy.

Global NuGet.config

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <!-- This needs to go through Proxy -->
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />

    <!-- This cannot go through Proxy. Has exclusion in NO_PRXY -->
    <add key="TeamCityInternal" value="http://nuget.internal/" />
  </packageSources>
</configuration>

And then we have

HTTP_PROXY=http://somproxy
NO_PROXY=.internal

This works perfectly fine when running nuget restore using nuget.exe versions v5.9.1 or v5.10.0-preview2

It doesn't work when running dotnet restore using .NET SDK 5.0.300 or .NET SDK 6.0.100-preview.4.

Using dotnet restore get a 403 forbidden error. (Proxy uses standard NTLM)

[nkolev92]

@michal-ciechan commented on Wed, 09 Jun 2021 09:26:43 GMT
5.0.301 still broken

[nkolev92]

@sfoslund commented on Wed, 09 Jun 2021 15:56:29 GMT
FYI @nkolev92

[nkolev92]

@nkolev92 commented on Wed, 09 Jun 2021 18:33:50 GMT
Dup in #10902.

cc @erdembayar who fixed it.

fyi @aortiz-msft, we might need to consider patching this.

[nkolev92]

@nkolev92 commented on Wed, 09 Jun 2021 18:38:49 GMT
For reference, the fix is available in the 5.0.400 dailies, dotnet/sdk#18041.

[erdembayar]

Here is link for daily build if someone wants to download 5.0.400 daily build
https://github.com/dotnet/installer/blob/main/README.md#installers-and-binaries

[erdembayar]

@nkolev92 commented on Wed, 09 Jun 2021 18:33:50 GMT
Dup in #10902.

cc @erdembayar who fixed it.

fyi @aortiz-msft, we might need to consider patching this.

Do you mean patching latest 5.0.30x? Can I just manually create PR or I have to use darc tool? Please let me know.

[nkolev92]

Triage: Fix available in 5.0.400, at this point no plans to service down level.