Conversation
This was referenced Jun 6, 2025
Open
Collaborator
|
(Feedback sent outside of GitHub) |
Contributor
Author
|
After the feedback, I implemented an alternative fix here: Nozbe/LokiJS@fcb4284 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues when working with multiple tabs. Sometimes, the collection's data is loaded into a loki/collection copy object that's passed to the
performSavefunction. This results in an error when trying to reaccess the data on the "main" loki/collection object.This should help with these issues:
All relevant changes are in the LokiJS repo: Nozbe/LokiJS@2c3ac90