Repository navigation
feat(cli): report a missing maigret in prism modules - #516
Open
geoggrigori wants to merge 1 commit into
Open
geoggrigori wants to merge 1 commit into
geoggrigori wants to merge 1 commit into
Conversation
`prism modules` answers "what will actually run?" from API keys, but maigret depends on a separate program: without it the module is reported skipped at scan time, while the listing showed it as ready. describe_modules() now adds `requires` and `found` to modules that need an external program. maigret is looked up the way maigret_wrapper does it (MAIGRET_BIN, then the project's venv-maigret, then PATH via shutil.which) without running it. The plain output says "binary not found, skipped at scan time"; --json carries the same. Closes NovaCode37#514 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HbB5TeSB4kZHBYDnQaSmBS
|
Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #514.
prism modulesnow says whether maigret, which runs as a separate program, can actually run.Changes
cli.py: aREQUIRED_BINARYtable (maigret→maigret) and_find_maigret(), which resolves the binary the waymodules/maigret_wrapper.pydoes:MAIGRET_BINfirst, then the project'svenv-maigret, thenPATHviashutil.which. It only looks for the file and never runs it, so the listing stays instant.describe_modules()adds"requires": "maigret"and"found": true|falseto modules that need an external program. Other rows are unchanged (the existingwhoisexact-match test still holds);blackbirdgets nothing, since it is pure Python.--jsoncarries the same ("requires": "maigret", "found": false).Type of change
Testing
tests/test_cli.py, patchingshutil.whichand the environment:blackbirdstays a bare line;--jsoncarriesrequires/foundfor maigret and nothing for blackbird;PATH;MAIGRET_BIN.pytest tests→ 571 passed; flake8 with CI's critical selection is clean on the touched files.🤖 Generated with Claude Code
https://claude.ai/code/session_01HbB5TeSB4kZHBYDnQaSmBS