Skip to content

Translate the empty and loading states in the results view #511

Description

@NovaCode37

#464 covers the DtRow field labels, but the results view also has empty and loading states written as English literals, so they show up in English in every locale:

frontend/src/components/views/ScanResults.tsx
  156  Loading map...
  170  No geolocation data available
  277  Loading graph...
  366  - add the key to .env to enable this module.
 1023  No security findings
 1110  No DNS records found
 1254  No threats detected
 1274  No threats detected

Line 366 is the hint under a skipped module, and it would also be better if it named the variable rather than saying ".env" in general. The module result already carries it in status_reason.

What to do:

  • Add the strings under results.common.* in messages/en.json (the two "No threats detected" share one key) and use them through t().
  • Add every key to all ten locale files by hand. npm run test:i18n checks they line up.

Done when none of these literals remain in ScanResults.tsx and npm run test:i18n and npm run build pass.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershacktoberfestOpen for Hacktoberfest contributionsjavascriptPull requests that update javascript code

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions