Skip to content

fix(cli): preserve spaces in path completion tokens#26520

Closed
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/path-completion-spaces
Closed

fix(cli): preserve spaces in path completion tokens#26520
haran2001 wants to merge 1 commit into
NousResearch:mainfrom
haran2001:fix/path-completion-spaces

Conversation

@haran2001
Copy link
Copy Markdown
Contributor

Summary

  • Preserve spaces inside path-like completion tokens
  • Stop at command/argument boundaries before explicit path prefixes
  • Add regression coverage for directories like ./My Documents/

Closes #26223

Test Plan

  • python -m pytest tests/hermes_cli/test_commands.py::TestPathCompletionHelpers -q

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have labels May 15, 2026
@alt-glitch
Copy link
Copy Markdown
Collaborator

Duplicate of #26230 — both fix #26223 (tab completion breaks on space-containing paths). Also competes with #26299.

@haran2001
Copy link
Copy Markdown
Contributor Author

Closing this one since it duplicates existing upstream PRs #26230/#26299 for #26223.

@haran2001 haran2001 closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tab completion stops working after completing a directory path containing spaces

2 participants