fix: Enforce lowercase usernames for profile queries

Nouhi · Mar 6, 2019 · c8f5b20 · c8f5b20
1 parent 92208f7
commit c8f5b20
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/client/src/client-only-routes/ShowProfileOrFourOhFour.js b/client/src/client-only-routes/ShowProfileOrFourOhFour.js
@@ -25,10 +25,10 @@ const propTypes = {
   showLoading: PropTypes.bool
 };
 
-const createRequestedUserSelector = () => (state, { maybeUser }) =>
-  userByNameSelector(maybeUser)(state);
-const createIsSessionUserSelector = () => (state, { maybeUser }) =>
-  maybeUser === usernameSelector(state);
+const createRequestedUserSelector = () => (state, { maybeUser = '' }) =>
+  userByNameSelector(maybeUser.toLowerCase())(state);
+const createIsSessionUserSelector = () => (state, { maybeUser = '' }) =>
+  maybeUser.toLowerCase() === usernameSelector(state);
 
 const makeMapStateToProps = () => (state, props) => {
   const requestedUserSelector = createRequestedUserSelector();

diff --git a/client/src/redux/fetch-user-saga.js b/client/src/redux/fetch-user-saga.js
@@ -27,9 +27,10 @@ function* fetchSessionUser() {
   }
 }
 
-function* fetchOtherUser({ payload: maybeUser }) {
+function* fetchOtherUser({ payload: maybeUser = '' }) {
   try {
-    const { data } = yield call(getUserProfile, maybeUser);
+    const maybeUserLC = maybeUser.toLowerCase();
+    const { data } = yield call(getUserProfile, maybeUserLC);
 
     const { entities: { user = {} } = {}, result = '' } = data;
     const otherUser = user[result] || {};

diff --git a/tools/scripts/seed/seedAuthUser.js b/tools/scripts/seed/seedAuthUser.js
@@ -44,7 +44,7 @@ MongoClient.connect(MONGOHQ_URL, { useNewUrlParser: true }, function(
         progressTimestamps: [],
         isBanned: false,
         isCheater: false,
-        username: 'DevelopmentUser',
+        username: 'developmentuser',
         about: '',
         name: 'Development User',
         location: '',