Add prometheus collector for meetings #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpslwk
approved these changes
Nov 9, 2024
AaronJackson
commented
Nov 9, 2024
|
|
||
| foreach ($meetings as $meeting) { | ||
| $meetingCounts[] = [ | ||
| $meeting->getProxies()->count(), |
There was a problem hiding this comment.
ARGH WHY DID I DO THAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking live dashboard in the hour running up to the meeting.
Might make sense to switch to
findNext()instead ofpaginateAllbut it would be nice to back fill previous AGMs. Happy to make a separate PR for that later if you like.Also might generally be a bit database heavy since it's pulling User objects instead of counts? (edit: are collections lazy loaded?)