Merge pull request #613 from AaronJackson/proxy-notifications-fix

Add variables to anonymous function scope for Trustee proxy notifications to Slack
NottingHack · Nov 30, 2024 · ef47000 · ef47000
2 parents 0ddd854 + 8717f8c
commit ef47000
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/app/Notifications/Governance/Proxy/NotifyTrusteesProxyCancelled.php b/app/Notifications/Governance/Proxy/NotifyTrusteesProxyCancelled.php
@@ -53,11 +53,10 @@ public function toSlack($notifiable)
 
         return (new SlackMessage)
             ->to($notifiable->getSlackChannel())
-            ->attachment(function ($attachment) {
-                $attachment->title($this->meeting->getTitle() . ': Proxy Cancelled')
+            ->attachment(fn ($attachment) => $attachment->title($this->meeting->getTitle() . ': Proxy Cancelled')
                             ->content($content)
                             ->fallback($content)
-                            ->timestamp(Carbon::now());
-            });
+                            ->timestamp(Carbon::now())
+            );
     }
 }
diff --git a/app/Notifications/Governance/Proxy/NotifyTrusteesProxyRegistered.php b/app/Notifications/Governance/Proxy/NotifyTrusteesProxyRegistered.php
@@ -55,11 +55,10 @@ public function toSlack($notifiable)
 
         return (new SlackMessage)
             ->to($notifiable->getSlackChannel())
-            ->attachment(function ($attachment) {
-                $attachment->title($meeting->getTitle() . ': Proxy Registered')
+            ->attachment(fn ($attachment) => $attachment->title($meeting->getTitle() . ': Proxy Registered')
                             ->content($content)
                             ->fallback($content)
-                            ->timestamp(Carbon::now());
-            });
+                            ->timestamp(Carbon::now())
+            );
     }
 }