Merge pull request #612 from AaronJackson/vendfix

Set snackspace product max short_description lengthto 25
NottingHack · Nov 23, 2024 · e168bfe · e168bfe
2 parents 7d22655 + 3910e10
commit e168bfe
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/app/HMS/Mappings/HMS.Entities.Snackspace.Product.dcm.yml b/app/HMS/Mappings/HMS.Entities.Snackspace.Product.dcm.yml
@@ -22,6 +22,7 @@ HMS\Entities\Snackspace\Product:
       nullable: true
     shortDescription:
       type: string
+      length: 25
     longDescription:
       type: text
       nullable: true

diff --git a/app/Http/Controllers/Snackspace/ProductController.php b/app/Http/Controllers/Snackspace/ProductController.php
@@ -69,7 +69,7 @@ public function create()
     public function store(Request $request)
     {
         $validatedData = $request->validate([
-            'shortDescription' => 'required|string|max:255',
+            'shortDescription' => 'required|string|max:25',
             'longDescription' => 'sometimes|nullable|string',
             'barcode' => 'sometimes|nullable|string|max:255',
             'price' => 'required|integer|min:1',
@@ -129,7 +129,7 @@ public function edit(Product $product)
     public function update(Request $request, Product $product)
     {
         $validatedData = $request->validate([
-            'shortDescription' => 'required|string|max:255',
+            'shortDescription' => 'required|string|max:25',
             'longDescription' => 'sometimes|nullable|string',
             'barcode' => 'sometimes|nullable|string|max255',
             'price' => 'required|integer|min:1',

diff --git a/...grations_doctrine/Version20241120222758_alter_snackspace_short_description_max_length.php b/...grations_doctrine/Version20241120222758_alter_snackspace_short_description_max_length.php
@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Database\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20241120222758_alter_snackspace_short_description_max_length extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return '';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE products CHANGE short_description short_description VARCHAR(25) NOT NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE products CHANGE short_description short_description VARCHAR(255) NOT NULL');
+    }
+}