Merge pull request ethereum#310 from etclabscore/fix/extraData

eth: update default extraData
NoteGio · Feb 3, 2021 · e24799e · e24799e
2 parents c3a0b59 + c9b3473
commit e24799e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/eth/backend.go b/eth/backend.go
@@ -250,7 +250,7 @@ func makeExtraData(extra []byte) []byte {
 		// create default extradata
 		extra, _ = rlp.EncodeToBytes([]interface{}{
 			uint(params.VersionMajor<<16 | params.VersionMinor<<8 | params.VersionPatch),
-			"geth",
+			"CoreGeth",
 			runtime.Version(),
 			runtime.GOOS,
 		})

diff --git a/eth/backend_test.go b/eth/backend_test.go
@@ -0,0 +1,12 @@
+package eth
+
+import (
+	"bytes"
+	"testing"
+)
+
+func TestMakeExtraDataDefault(t *testing.T) {
+	if !bytes.Contains(makeExtraData(nil), []byte("CoreGeth")) {
+		t.Error("missing extra data default client identifier")
+	}
+}