Control panel info type #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddfreiling
requested changes
Oct 6, 2025
Member
ddfreiling
left a comment
ddfreiling
left a comment
There was a problem hiding this comment.
Seems good logically, needs a bit of formatting.
...ter_readium/ios/flutter_readium/Sources/flutter_readium/FlutterReadiumPlugin+Audiobook.swift
Outdated
Show resolved
Hide resolved
...ter_readium/ios/flutter_readium/Sources/flutter_readium/FlutterReadiumPlugin+Audiobook.swift
Outdated
Show resolved
Hide resolved
...ter_readium/ios/flutter_readium/Sources/flutter_readium/FlutterReadiumPlugin+Audiobook.swift
Outdated
Show resolved
Hide resolved
flutter_readium/ios/flutter_readium/Sources/flutter_readium/ReadiumExtensions.swift
Outdated
Show resolved
Hide resolved
Member
|
Swift code should be 2-space indented. I have added a |
* feat/audiobook-navigator: (27 commits) chore: replace audiobook test book chore(example): support ToC tree-structure and some styling fix: locator not deserialized correctly on android chore: remove demo fakeInitialLocator fix(iOS): properly deserialize Locator in audioEnable fix: send goToLocator args as list to native fix: register and call goToLocator feat(android): goToLocator feat: add goToLocator for media feat: add timebased.state.widget for audiobooks feat: add ToC restructure PublicationMethodCallHandler fix: remove streams from player-controls-bloc chor: add missing extension feat: add error-event stream chore: subscribe to all playback state feat: ReadiumTimebasedState stream now working feat(Android): setup EventChannel for ReadiumTimebasedState fix(example): Play event should resume if audio is already enabled start ReadiumTimebasedState on android ...
Collaborator
|
I'm getting some compile error from kotlin from yesterdays changes.
The preferences editor should probably just be removed, like I did on the AudiobookNavigator. |
Collaborator
|
I fixed the compile error and ensured the new preference type is store in the state. |
m-abs
force-pushed
the
control-panel-info-type
branch
from
622a190 to
08047a5
Compare
ddfreiling
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.