fix/android crash fragment #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
m-abs
commented
Jun 13, 2025
m-abs
commented
- feat: moved into a wrapper fragment class
- new fragmenet is now used
- fix: fragment init must be without arguments
ddfreiling
approved these changes
Jun 17, 2025
| return false; | ||
| } | ||
| // Checks also that the locator also contains `active` class. | ||
| // TODO: This doesn't do what we expect, if the range is visible but not active, this function will return false. |
Member
There was a problem hiding this comment.
We actually fixed this on the lyt4 branch, we need to backport it here.
…er_readium into fix/android-crash-fragment
Not pretty but better
ddfreiling
approved these changes
Jul 1, 2025
Member
ddfreiling
left a comment
ddfreiling
left a comment
There was a problem hiding this comment.
Awesome job 🚀
Minor readability comment.
| it.locator = initialLocator | ||
| it.preferences = initialPreferences | ||
|
|
||
| it |
Member
There was a problem hiding this comment.
This use of let hurts readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.