Skip to content

Conversation

alfarelcynthesis
Copy link
Contributor

These are all cases where just using another module argument works better,
and adapts to codebase changes more easily.

I'm trying to figure out the default keymap toggle issue and having multiple entrypoints to some modules makes sed less universal.

This seems like technical debt that just hasn't yet been removed, so I figured I should just PR it asap separately.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
    Evaluation is exactly the same.
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Reduces maintenance burden.
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

🚀 Live preview deployed from 06bc21e

View it here:

Debug Information

Triggered by: horriblename

HEAD at: less-import

Reruns: 1444

Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@horriblename horriblename merged commit 06bc21e into NotAShelf:v0.8 Sep 27, 2025
14 checks passed
@github-actions
Copy link

✅ Preview has been deleted successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants