Zenoh bridge#133
Open
jr1221 wants to merge 3 commits into
Open
Conversation
jr1221
marked this pull request as ready for review
July 11, 2026 02:40
| .as_millis() as u64; | ||
| warn!("HV status permanently set on!!"); | ||
| if let Err(err) = | ||
| std::fs::create_dir(format!("{}/event-{}", SAVE_LOCATION.get().unwrap(), time)) |
Contributor
There was a problem hiding this comment.
Aren't you already doing this logic in the receive handler of the zenoh processor?
Contributor
Author
There was a problem hiding this comment.
Yes there is some code copy paste but the reason this exists is because oft he augment HV on flag. It initializes the library pretending such a message was received at boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Explanation of changes goes here
Added:
Notes
Any other notes go here
There is code duplication between mqtt_handler, zenoh_bridge, and zenoh_handler. I do not care because I fully expected mqtt_handler and zenoh_bridge to be deprecated and eventually deleted.
Test Cases
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes # (issue #)