Skip to content

#4315 editing rule codes#4334

Open
cielbellerose wants to merge 13 commits into
feature/rules-dashboardfrom
#4315-editing-rule-codes
Open

#4315 editing rule codes#4334
cielbellerose wants to merge 13 commits into
feature/rules-dashboardfrom
#4315-editing-rule-codes

Conversation

@cielbellerose

@cielbellerose cielbellerose commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Changes

Edit rule code functionality added

Notes

  • Rule content is now allowed to be empty on create & edit
  • Update add rule modal to autofill with parent rule code
  • Warning if adding new rule doesn't match parent rule code
  • Warning modal for editing rule code if parent or children are misaligned

Notes

Decided to allow parents and children to have misaligned rule codes by recommending but not strictly enforcing rule code prefixes

Screenshots

Screenshot 2026-07-17 at 10 42 17 PM Screenshot 2026-07-20 at 10 20 59 AM Screenshot 2026-07-20 at 10 20 44 AM Screenshot 2026-07-19 at 11 29 20 AM Screenshot 2026-07-19 at 11 56 06 AM Screenshot 2026-07-17 at 10 41 47 PM Screenshot 2026-07-20 at 10 29 38 AM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4315

@cielbellerose cielbellerose linked an issue Jul 18, 2026 that may be closed by this pull request
5 tasks
@cielbellerose
cielbellerose changed the base branch from develop to feature/rules-dashboard July 18, 2026 02:36
@cielbellerose cielbellerose self-assigned this Jul 19, 2026
@cielbellerose
cielbellerose marked this pull request as ready for review July 20, 2026 14:31
Comment thread src/backend/src/routes/rules.routes.ts
Comment thread src/frontend/src/pages/RulesPage/RulesetEditPage.tsx Outdated
Comment thread src/backend/src/services/rules.services.ts
Comment thread src/frontend/src/pages/RulesPage/AssignRulesTab.tsx Outdated
Comment thread src/backend/src/services/rules.services.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RulesDashboard] - Editing Rule Codes

2 participants