Fixes #28374: ADR for Generic Method#6929
Conversation
| @@ -0,0 +1,80 @@ | |||
| # [Simpler method logger without suffix] | |||
There was a problem hiding this comment.
| # [Simpler method logger without suffix] | |
| # Simpler method logger without suffix |
Fdall
force-pushed
the
arch_28374/adr_for_generic_method
branch
from
a9d59bd to
f378f73
Compare
|
Commit modified |
Fixes #28374: ADR for Generic Method
|
PR updated with a new commit |
P4uline
left a comment
P4uline
left a comment
There was a problem hiding this comment.
It's so nice to have ADR's about generic methods, it's helpful also for the webapp team. Thanks for the detailed specification.
Just have some feedbacks about ADR formatting.
|
|
||
| **This ADR applies to all Generic Methods starting 9.1. Existing and future ones.** | ||
|
|
||
| ## Decision: |
There was a problem hiding this comment.
I would say, there is too many information in the decision section so it is very difficult to understand what is the decision.
Maybe everything that is a specification could be moved in another section (Details or Examples), or even outside the repository (notion or any other tool... ) and referenced with a link ?
That way we could have only a few sentences to describe the decision which would be more clear.
WDYT ?
|
|
||
| ## Decision: | ||
|
|
||
| - A **Generic Method** (GM) is a configurable policy execution unit based on a declarative system |
There was a problem hiding this comment.
Reading more carefully, what I understand is that the actual decision would be something like :
Decision
The new generic methods must follow these guidelines:
- naming convention
- the return status must follow a pattern (see details)
- foreach loop case: keep the worst case
- have a companion agent bundle file
- have mandatory fields
- return a Rudder report
see detailed specification
It just a proposal, but it would be nice to keep the decision section simple and small :)
3 participants
https://issues.rudder.io/issues/28374