Fixes #20372: there is no validation on the variable name in generic method variable_from_smth #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method variable_from_smth
amousset
reviewed
Dec 6, 2021
| # @parameter variable_name The variable to define, the full name will be variable_prefix.variable_name | ||
| # @parameter value The variable content in JSON format | ||
| # @parameter variable_prefix The prefix of the variable name | ||
| # @parameter_constraint variable_prefix "regex" : "^[A-z0-9_]+$" |
There was a problem hiding this comment.
A-z matches non letter chars too.
There was a problem hiding this comment.
We should use something like A-Za-z instead.
There was a problem hiding this comment.
plus we need to make it possible to use a variable here, I don't remember if we have a mechanism on server part to skip constraint check in this case
There was a problem hiding this comment.
this mecanism should be server side, otherwise we would need to adapt every regex
…eneric method variable_from_smth Fixes #20372: there is no validation on the variable name in generic method variable_from_smth
ncharles
added
Trigger test
|
PR updated with a new commit |
|
@ncharles is this really a wip ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/20372