allow to specify the type of ref returned by useFocusable
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Originally, `E` was `extends HTMLElement = HTMLElement`, but that made the new type arg effectively requred because of `Type 'RefObject<HTMLElement>' is not assignable to type 'Ref<HTMLDivElement>'.` - `src/App.tsx` should passes type check without changes in this commit, but adding the new type arg seemed like a correct thing to do in the example
tomasz-rekawek
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E extends HTMLElement = HTMLElement, but that made the new type arg effectively required because ofType 'RefObject<HTMLElement>' is not assignable to type 'Ref<HTMLDivElement>'.src/App.tsxshould passes type check without changes in this PR, but adding the new type arg seemed like a correct thing to do in the example